fix: reply -32700 on stdio parse errors instead of closing#833
Open
fix: reply -32700 on stdio parse errors instead of closing#833
Conversation
github-actions
Bot
added
T-core
DaleSeo
force-pushed
the
fix/issue-825-stdio-parse-error
branch
from
0d39c02 to
69b254b
Compare
DaleSeo
force-pushed
the
fix/issue-825-stdio-parse-error
branch
from
69b254b to
93873ad
Compare
alexhancock
approved these changes
May 6, 2026
| // Hardcoded bytes because `RequestId` has no `Null` variant — we can't | ||
| // build an `id: null` JsonRpcError through the typed codec. | ||
| const PARSE_ERROR_RESPONSE: &[u8] = | ||
| b"{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32700,\"message\":\"Parse error\"},\"id\":null}\n"; |
Contributor
There was a problem hiding this comment.
is there really no way to build something we can serialize to get this value instead of hardcoding it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #825
Motivation and Context
The RMCP stdio transport used to close the stream silently when it encountered a malformed line. This made it hard for clients to tell the difference between a parse failure and a normal end-of-file initiated by the peer. Just one bad byte could bring down the entire session.
Now, the stdio transport responds with a JSON-RPC
-32700 Parse errorwhen it receives a malformed line, instead of closing the stream silently. It also removes a leading UTF-8 BOM, so messages from Windows tools that have a BOM prefix can be parsed correctly.How Has This Been Tested?
Added new tests
Breaking Changes
None.
Types of changes
Checklist
Additional context